Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump temporal_rs and fix instant return #4142

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump temporal_rs and fix instant return #4142

wants to merge 1 commit into from

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jan 23, 2025

This Pull Request is related to ongoing work for #1804.

It changes the following:

  • Fixes the returned value of Instant::get_epoch_milliseconds
  • Bumps temporal_rs with some bug fixes
  • Adjusts some method names due to temporal_rs changes

@github-actions GitHub Actions
Copy link

Test262 conformance changes

Test result main count PR count difference
Total 50,254 50,254 0
Passed 45,924 46,018 +94
Ignored 1,634 1,634 0
Failed 2,696 2,602 -94
Panics 0 0 0
Conformance 91.38% 91.57% +0.19%
Fixed tests (98): 
test/built-ins/Temporal/PlainDate/prototype/toPlainDateTime/limits.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/subtract/argument-duration-out-of-range.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/subtract/argument-not-object.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/rounding-relative.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/zero-length-duration-result.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/largestunit-year.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/largestunit-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/weeks-months.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/wrapping-at-end-of-month.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/largestunit-day.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/largestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/largestunit-higher-units.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/largestunit-month.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/until/largestunit-week.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/argument-duration-out-of-range.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/argument-string-invalid.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/add/argument-not-object.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/rounding-relative.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/largestunit-wrong-type.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/weeks-months.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/largestunit.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/wrapping-at-end-of-month.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/largestunit-plurals-accepted.js (previously Failed)
test/built-ins/Temporal/PlainDate/prototype/since/largestunit-higher-units.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/subtract/argument-duration-out-of-range.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/subtract/argument-not-object.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/subtract/argument-string-duration-too-large.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/add/argument-duration-out-of-range.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/add/argument-not-object.js (previously Failed)
test/built-ins/Temporal/PlainTime/prototype/add/argument-string-duration-too-large.js (previously Failed)
test/built-ins/Temporal/Instant/basic.js (previously Failed)
test/built-ins/Temporal/Instant/from/argument-string.js (previously Failed)
test/built-ins/Temporal/Instant/from/instant-string.js (previously Failed)
test/built-ins/Temporal/Instant/from/instant-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/Instant/from/basic.js (previously Failed)
test/built-ins/Temporal/Instant/from/argument-string-limits.js (previously Failed)
test/built-ins/Temporal/Instant/from/instant-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/Instant/from/timezone-custom.js (previously Failed)
test/built-ins/Temporal/Instant/compare/instant-string.js (previously Failed)
test/built-ins/Temporal/Instant/compare/instant-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/Instant/compare/argument-string-limits.js (previously Failed)
test/built-ins/Temporal/Instant/compare/instant-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/equals/instant-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/equals/argument-string-limits.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/equals/instant-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/subtract/argument-duration-out-of-range.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/subtract/minimum-maximum-instant.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/subtract/argument-not-object.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/rounding-increments.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/instant-string.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/instant-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/argument-string-limits.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/until/instant-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/add/argument-duration-out-of-range.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/add/minimum-maximum-instant.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/add/argument-not-object.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/rounding-increments.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/instant-string.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/instant-string-multiple-offsets.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/argument-string-limits.js (previously Failed)
test/built-ins/Temporal/Instant/prototype/since/instant-string-sub-minute-offset.js (previously Failed)
test/built-ins/Temporal/Duration/from/argument-string-fractional-with-zero-subparts.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/argument-string.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/subtract/argument-not-object.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/argument-string.js (previously Failed)
test/built-ins/Temporal/Duration/prototype/add/argument-not-object.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/overflow-undefined.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/offset-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/disambiguation-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/from/argument-string-negative-extended-year.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/withTimeZone/preserves-instant.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/argument-duration-out-of-range.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/overflow-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/subtract/argument-not-object.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/until/casts-argument.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/argument-duration-out-of-range.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/overflow-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/add/argument-not-object.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/since/largestunit-wrong-type.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/since/largestunit.js (previously Failed)
test/built-ins/Temporal/ZonedDateTime/prototype/since/balance-negative-time-units.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/subtract/argument-duration-out-of-range.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/subtract/argument-not-object.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/add/argument-duration-out-of-range.js (previously Failed)
test/built-ins/Temporal/PlainYearMonth/prototype/add/argument-not-object.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/limits.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/from/argument-string-limits.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/compare/argument-string-limits.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/round/limits.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/equals/argument-string-limits.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/subtract/argument-duration-out-of-range.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/subtract/argument-duration-max.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/subtract/argument-not-object.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/until/argument-string-limits.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/add/argument-duration-out-of-range.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/add/argument-duration-max.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/add/argument-not-object.js (previously Failed)
test/built-ins/Temporal/PlainDateTime/prototype/since/argument-string-limits.js (previously Failed)
Broken tests (4): 
test/built-ins/Temporal/PlainTime/prototype/until/largestunit-invalid-string.js (previously Passed)
test/built-ins/Temporal/PlainTime/prototype/since/largestunit-invalid-string.js (previously Passed)
test/built-ins/Temporal/Instant/prototype/until/largestunit-invalid-string.js (previously Passed)
test/built-ins/Temporal/Instant/prototype/since/largestunit-invalid-string.js (previously Passed)

@nekevss
Copy link
Member Author

nekevss commented Jan 23, 2025

The broken tests in this case are interesting. I'm looking into it.

@nekevss nekevss mentioned this pull request Jan 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nekevss